<div dir="ltr">I think I'm wrong here actually, while this does work, it's not enough as a lot of other code in LLLexer as it assumes no range checks.<div>It would probably be better to go with the original patch with a null terminating character, as the LLLexer will require a lot of range </div><div>checks to be bug free when working with the non-null terminated input.</div><div><div class="gmail_extra"><br><div class="gmail_quote">2015-05-20 12:36 GMT-07:00 Alex Lorenz <span dir="ltr"><<a href="mailto:arphaman@gmail.com" target="_blank">arphaman@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I updated the patch to use a range check in the LLLexer instead of relying on the null character for EOF.<br>
<br>
<br>
REPOSITORY<br>
  rL LLVM<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D9883&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=H_vn7O2n9SqE60WqGBcfyRwN02M6Biq-LTcBseScoxs&s=5iv85DqPaAIZQgL6KxlHv-oeyNtooWE6mqIZqs1mEys&e=" target="_blank">http://reviews.llvm.org/D9883</a><br>
<br>
Files:<br>
  lib/AsmParser/LLLexer.cpp<br>
  unittests/AsmParser/AsmParserTest.cpp<br>
  unittests/AsmParser/CMakeLists.txt<br>
  unittests/AsmParser/Makefile<br>
  unittests/CMakeLists.txt<br>
  unittests/Makefile<br>
<br>
EMAIL PREFERENCES<br>
  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=H_vn7O2n9SqE60WqGBcfyRwN02M6Biq-LTcBseScoxs&s=TtgfY9y2NbouuQx74ZcwY3a12hZyh2HHr9t8rKj5rQU&e=" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
</blockquote></div><br></div></div></div>