[LNT] r237660 - Reorder checks from stronger to weaker

Chris Matthews cmatthews5 at apple.com
Mon May 18 18:59:25 PDT 2015


Author: cmatthews
Date: Mon May 18 20:59:25 2015
New Revision: 237660

URL: http://llvm.org/viewvc/llvm-project?rev=237660&view=rev
Log:
Reorder checks from stronger to weaker

Modified:
    lnt/trunk/lnt/server/reporting/analysis.py

Modified: lnt/trunk/lnt/server/reporting/analysis.py
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/reporting/analysis.py?rev=237660&r1=237659&r2=237660&view=diff
==============================================================================
--- lnt/trunk/lnt/server/reporting/analysis.py (original)
+++ lnt/trunk/lnt/server/reporting/analysis.py Mon May 18 20:59:25 2015
@@ -133,13 +133,7 @@ class ComparisonResult:
         if self.failed:
             return UNCHANGED_FAIL
         elif self.prev_failed:
-            return UNCHANGED_PASS
-
-        # Ignore tests whose delta is too small relative to the precision we can
-        # sample at; otherwise quantization means that we can't measure the
-        # standard deviation with enough accuracy.
-        if abs(self.delta) <= 2 * value_precision * confidence_interval:
-            return UNCHANGED_PASS
+            return UNCHANGED_PASS 
 
         # Always ignore percentage changes below 1%, for now, we just don't have
         # enough time to investigate that level of stuff.
@@ -153,10 +147,17 @@ class ComparisonResult:
         if ignore_small and abs(self.delta) < .01:
             return UNCHANGED_PASS
 
+        # Ignore tests whose delta is too small relative to the precision we can
+        # sample at; otherwise quantization means that we can't measure the
+        # standard deviation with enough accuracy.
+        if abs(self.delta) <= 2 * value_precision * confidence_interval:
+            return UNCHANGED_PASS
+
         # Use Mann-Whitney U test to test null hypothesis that result is
         # unchanged.
         if len(self.samples) >= 4 and len(self.prev_samples) >= 4:
-            same = stats.mannwhitneyu(self.samples, self.prev_samples, self.confidence_lv)
+            same = stats.mannwhitneyu(self.samples, self.prev_samples,
+                                      self.confidence_lv)
             if same:
                 return UNCHANGED_PASS
 





More information about the llvm-commits mailing list