[PATCH] [mips] [IAS] Add support for BNE and BEQ with an immediate operand.
Toma Tabacu
toma.tabacu at imgtec.com
Thu May 14 03:39:58 PDT 2015
Replied to inline comment.
================
Comment at: lib/Target/Mips/MipsInstrInfo.td:1676
@@ +1675,3 @@
+def BneImm : MipsAsmPseudoInst<(outs GPR32Opnd:$rt),
+ (ins uimm5:$imm32, brtarget:$offset),
+ "bne\t$rt, $imm32, $offset">;
----------------
dsanders wrote:
> I don't think you mean uimm5 here. Doesn't this accept a 32-bit immediate?
I'm not sure what to put here. I chose uimm5 because that's what LoadImm32 and LoadAddrImm32 use.
http://reviews.llvm.org/D9666
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list