[PATCH] [mips] [IAS] Add support for BNE and BEQ with an immediate operand.

Daniel Sanders daniel.sanders at imgtec.com
Wed May 13 03:17:24 PDT 2015


LGTM with the correct operand.


================
Comment at: lib/Target/Mips/MipsInstrInfo.td:1676
@@ +1675,3 @@
+def BneImm : MipsAsmPseudoInst<(outs GPR32Opnd:$rt),
+                               (ins uimm5:$imm32, brtarget:$offset),
+                               "bne\t$rt, $imm32, $offset">;
----------------
I don't think you mean uimm5 here. Doesn't this accept a 32-bit immediate?

================
Comment at: lib/Target/Mips/MipsInstrInfo.td:1679
@@ +1678,3 @@
+def BeqImm : MipsAsmPseudoInst<(outs GPR32Opnd:$rt),
+                               (ins uimm5:$imm32, brtarget:$offset),
+                               "beq\t$rt, $imm32, $offset">;
----------------
Likewise

http://reviews.llvm.org/D9666

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list