[PATCH] Sparc: support the "set" synthetic instruction.

Eric Christopher echristo at gmail.com
Wed May 13 15:23:48 PDT 2015


LGTM with an inline comment to fix up. If there's going to be more of these you might want to look into a processInstruction routine ala ARM.

-eric


================
Comment at: lib/Target/Sparc/AsmParser/SparcAsmParser.cpp:431
@@ +430,3 @@
+                               SmallVectorImpl<MCInst> &Instructions,
+                               MCContext &OutContext) {
+  MCOperand MCRegOp = Inst.getOperand(0);
----------------
No need to pass this in, you can just use getContext().

Feel free to clean up any other uses as well.

http://reviews.llvm.org/D9089

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list