[PATCH] TableGen: AsmMatcherEmitter: Don't use custom converters for instruction aliases

Ahmed Bougacha ahmed.bougacha at gmail.com
Wed May 13 14:42:15 PDT 2015


LGTM, thanks!


================
Comment at: utils/TableGen/AsmMatcherEmitter.cpp:441
@@ -440,1 +440,3 @@
 
+  /// If this is an alias, this is use to determine whether or not to using
+  /// the conversion function defined by the instruction's AsmMatchConverter
----------------
this is use to determine whether or not to using
->
this is used to determine whether or not to use

================
Comment at: utils/TableGen/AsmMatcherEmitter.cpp:443
@@ +442,3 @@
+  /// the conversion function defined by the instruction's AsmMatchConverter
+  /// or to use the function generated by the alias.
+  bool UseInstAsmMatchConverter;
----------------
generated by -> generated for?  Might be clearer.  (same in Target.td)

http://reviews.llvm.org/D9083

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list