[PATCH] [LLVM - ARM/AArch64] Add ACLE special register intrinsics (10.1)

Luke Cheeseman luke.cheeseman at arm.com
Wed May 13 08:20:27 PDT 2015


Renato,

Thanks for the suggestions, I've tried to tidy up the main functions by extracting some of the code for setting the masks into some helper functions, I could perhaps do more to completely extract the setting of the masks (for example in the later part of the write lowering). I haven't placed the parsing of apsr, cpsr and spsr into the switch as I thought it wasn't part of what either switch was trying to do as it wasn't trying to get a mask value and so I've left it in the main part of the lowering. I'd welcome any more suggestions you have.

Thanks,
Luke


http://reviews.llvm.org/D9699

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list