[PATCH] [mips] Make TTypeEncoding indirect to allow .eh_frame to be read-only.

Daniel Sanders daniel.sanders at imgtec.com
Mon May 11 14:09:00 PDT 2015


================
Comment at: lib/MC/MCObjectFileInfo.cpp:328
@@ -329,1 +327,3 @@
+    // MIPS uses indirect pointer to refer personality functions and types, so
+    // that the eh_frame section can be read-only. DW.ref.personality will be generated
     // for relocation.
----------------
joerg wrote:
> Is this within 80columns? It looked very long.
It's 87. I've fixed it in my working copy.

I normally have clang-format as part of a pre-commit hook but it looks like I've forgotten to install it on a new git-clone again. Thanks for noticing.

================
Comment at: lib/Target/Mips/MipsAsmPrinter.cpp:1073
@@ -1052,1 +1072,3 @@
+  }
+
   // return to the text section
----------------
joerg wrote:
> Why is this chunk needed? TargetLoweringObjectFileELF::getTTypeGlobalReference is not handling this already?
It was needed for the LLVM that's in AOSP but it looks like that might not be the case on the trunk. It seems Rafael refactored the other instances of this about a month ago. I'll look into it.

http://reviews.llvm.org/D9669

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list