[PATCH] [mips] Make TTypeEncoding indirect to allow .eh_frame to be read-only.

Joerg Sonnenberger joerg at NetBSD.org
Mon May 11 10:17:55 PDT 2015


================
Comment at: lib/MC/MCObjectFileInfo.cpp:328
@@ -329,1 +327,3 @@
+    // MIPS uses indirect pointer to refer personality functions and types, so
+    // that the eh_frame section can be read-only. DW.ref.personality will be generated
     // for relocation.
----------------
Is this within 80columns? It looked very long.

================
Comment at: lib/Target/Mips/MipsAsmPrinter.cpp:1073
@@ -1052,1 +1072,3 @@
+  }
+
   // return to the text section
----------------
Why is this chunk needed? TargetLoweringObjectFileELF::getTTypeGlobalReference is not handling this already?

http://reviews.llvm.org/D9669

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list