[PATCH] [PowerPC]Adapt fast stack unwinding to work for Power.

Evgeniy Stepanov eugenis at google.com
Wed May 6 14:27:34 PDT 2015


================
Comment at: /home/seurer/llvm/llvm-test/projects/compiler-rt/lib/sanitizer_common/sanitizer_stacktrace.cc:93
@@ +92,3 @@
+  if (FAST_UNWIND_SHOULD_POP_FRAMES_TO_PC) {
+    PopStackFramesToPc(pc);
+  }
----------------
I don't fully understand why this is needed. In line 73 we have "trace_buffer[0] = pc" which is supposed to ensure that pc is, in fact, in the first stack frame. What is the effect of this call? Could you show the example of a stack trace with undesirable frames on top?

http://reviews.llvm.org/D9259

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list