[PATCH] [StatepointLowering] Don't create temporary instructions. NFCI.

[Sanjoy Das]

On Tue, May 5, 2015 at 5:44 PM, Philip Reames <listmail at philipreames.com> wrote:
> LGTM w/the requirement that you write a test which would have failed with your previous version and include it with the submission.

It looks like such a test, where the called function does not def a
value since it is void, is already there in
statepoint-call-lowering.ll.  It does not look like SelectionDAG has
asserts if you setValue(<void call>, something) so that test does not
fail.

>
>
> ================
> Comment at: lib/CodeGen/SelectionDAG/StatepointLowering.cpp:281
> @@ -280,3 @@
> -
> -  // Search for the call node
> -  // The following code is essentially reverse engineering X86's
> ----------------
> I would prefer you kept this comment in the new code.  I regularly use it to remind myself what's going on here.
>
> http://reviews.llvm.org/D9480
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>