[PATCH] [StatepointLowering] Don't create temporary instructions. NFCI.

Philip Reames listmail at philipreames.com
Tue May 5 17:44:08 PDT 2015


LGTM w/the requirement that you write a test which would have failed with your previous version and include it with the submission.


================
Comment at: lib/CodeGen/SelectionDAG/StatepointLowering.cpp:281
@@ -280,3 @@
-
-  // Search for the call node
-  // The following code is essentially reverse engineering X86's
----------------
I would prefer you kept this comment in the new code.  I regularly use it to remind myself what's going on here.

http://reviews.llvm.org/D9480

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list