Modulo comments already made by others, this LGTM. I assume you'll be adding the other f32 VSX instructions in the near future. REPOSITORY rL LLVM http://reviews.llvm.org/D9440 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/