[PATCH] Add a speculative execution pass

Mark Heffernan meheff at google.com
Tue May 5 14:07:48 PDT 2015


================
Comment at: lib/Transforms/Scalar/SpeculativeExecution.cpp:64
@@ +63,3 @@
+             "the number of instructions that cannot be speculatively executed "
+             "do not exceed this limit."));
+
----------------
The double negative at the end of this description confused me as written.  Maybe:  "Speculative execution is not be applied to basic blocks where the number of ... exceeds this limit."

Could change the other option description to match.

================
Comment at: lib/Transforms/Scalar/SpeculativeExecution.cpp:146
@@ +145,3 @@
+        return 1;
+      return 2; // Changed by Jingyue.
+
----------------
Stale comment?

================
Comment at: lib/Transforms/Scalar/SpeculativeExecution.cpp:159
@@ +158,3 @@
+    case Instruction::ZExt:
+    case Instruction::SExt:
+      return 1; // These are all cheap.
----------------
Instruction::And?  Can you use TTI instruction costs here?

http://reviews.llvm.org/D9360

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list