[PATCH] Add a speculative execution pass
hfinkel at anl.gov
hfinkel at anl.gov
Tue May 5 14:28:46 PDT 2015
================
Comment at: include/llvm/Transforms/Scalar.h:426
@@ -425,1 +425,3 @@
//
+// SpeculativeExecution - Speculatively execute instructions.
+//
----------------
This pass does not speculatively execute anything. Please reword.
================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:236
@@ +235,3 @@
+ if (RunSpeculation)
+ MPM.add(createSpeculativeExecutionPass());
+
----------------
This is pretty early in the pipeline, why? Do you want LICM to run first?
================
Comment at: lib/Transforms/Scalar/SpeculativeExecution.cpp:147
@@ +146,3 @@
+ return 2; // Changed by Jingyue.
+
+ case Instruction::Add:
----------------
And should this depend on the number of non-constant indices?
http://reviews.llvm.org/D9360
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list