[PATCH] Add a DWOId field to DICompileUnit (so DWARF skeleton CUs can be expression in IR).

Adrian Prantl aprantl at apple.com
Mon May 4 16:04:25 PDT 2015


Maybe I’m missing something.
Wouldn’t llvm-as always create the new form? In textual IR there is no way to distinguish between a DICompileUnit with a zero DWOId field and one without DWOId field.

-- adrian
> On May 4, 2015, at 4:01 PM, Eric Christopher <echristo at gmail.com> wrote:
> 
> You can use llvm-as %s -o - | llvm-dis | FileCheck or something similar.
> 
> -eric
> 
> On Mon, May 4, 2015 at 4:00 PM Adrian Prantl <aprantl at apple.com <mailto:aprantl at apple.com>> wrote:
> Here's the requested autoupgrade code.
> 
> Duncan, is the ad-hoc fashion I implemented this the way to go, or is there a way to better separate the upgrades from the parser?
> Also, is there a way to test the autoupgrade without checking in binary bitcode?
> 
> 
> http://reviews.llvm.org/D9488 <http://reviews.llvm.org/D9488>
> 
> Files:
>   include/llvm/IR/DIBuilder.h
>   include/llvm/IR/DebugInfoMetadata.h
>   lib/AsmParser/LLParser.cpp
>   lib/Bitcode/Reader/BitcodeReader.cpp
>   lib/Bitcode/Writer/BitcodeWriter.cpp
>   lib/IR/AsmWriter.cpp
>   lib/IR/DIBuilder.cpp
>   lib/IR/DebugInfoMetadata.cpp
>   lib/IR/LLVMContextImpl.h
>   test/Assembler/mdcompileunit.ll
>   unittests/IR/MetadataTest.cpp
> 
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/ <http://reviews.llvm.org/settings/panel/emailpreferences/>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150504/157fd7a5/attachment.html>


More information about the llvm-commits mailing list