<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Maybe I’m missing something.<div class="">Wouldn’t llvm-as always create the new form? In textual IR there is no way to distinguish between a DICompileUnit with a zero DWOId field and one without DWOId field.</div><div class=""><br class=""></div><div class="">-- adrian<br class=""><div><blockquote type="cite" class=""><div class="">On May 4, 2015, at 4:01 PM, Eric Christopher <<a href="mailto:echristo@gmail.com" class="">echristo@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">You can use llvm-as %s -o - | llvm-dis | FileCheck or something similar.<br class=""><br class="">-eric<br class=""></div><br class=""><div class="gmail_quote">On Mon, May 4, 2015 at 4:00 PM Adrian Prantl <<a href="mailto:aprantl@apple.com" class="">aprantl@apple.com</a>> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Here's the requested autoupgrade code.<br class="">
<br class="">
Duncan, is the ad-hoc fashion I implemented this the way to go, or is there a way to better separate the upgrades from the parser?<br class="">
Also, is there a way to test the autoupgrade without checking in binary bitcode?<br class="">
<br class="">
<br class="">
<a href="http://reviews.llvm.org/D9488" target="_blank" class="">http://reviews.llvm.org/D9488</a><br class="">
<br class="">
Files:<br class="">
include/llvm/IR/DIBuilder.h<br class="">
include/llvm/IR/DebugInfoMetadata.h<br class="">
lib/AsmParser/LLParser.cpp<br class="">
lib/Bitcode/Reader/BitcodeReader.cpp<br class="">
lib/Bitcode/Writer/BitcodeWriter.cpp<br class="">
lib/IR/AsmWriter.cpp<br class="">
lib/IR/DIBuilder.cpp<br class="">
lib/IR/DebugInfoMetadata.cpp<br class="">
lib/IR/LLVMContextImpl.h<br class="">
test/Assembler/mdcompileunit.ll<br class="">
unittests/IR/MetadataTest.cpp<br class="">
<br class="">
EMAIL PREFERENCES<br class="">
<a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank" class="">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br class="">
</blockquote></div>
</div></blockquote></div><br class=""></div></body></html>