3.6.1 patch nomination: r231984 & r232176 (illegal type support fixes)

Paweł Bylica chfast at gmail.com
Wed Apr 29 08:41:37 PDT 2015


Sure, I'm on it.

On Wed, Apr 29, 2015 at 5:39 PM Tom Stellard <tom at stellard.net> wrote:

> Hi,
>
> r236108 breaks make check on the 3.6 branch, because it uses the
> 3.7 syntax for load and getelementptr.  Could you commit a fix.
>
> Thanks,
> Tom
>
> On Wed, Apr 29, 2015 at 03:01:12PM +0000, Paweł Bylica wrote:
> > Merged as r236108 and r236109.
> >
> > On Mon, Apr 20, 2015 at 6:58 PM Owen Anderson <resistor at mac.com> wrote:
> >
> > >
> > > > On Apr 20, 2015, at 8:30 AM, Tom Stellard <tom at stellard.net> wrote:
> > > >
> > > > On Wed, Mar 18, 2015 at 12:56:59PM +0000, Paweł Bylica wrote:
> > > >> --------------------------------------------------------------------
> > > >> r231984:
> > > >>
> > > >> URL: http://llvm.org/viewvc/llvm-project?rev=231984&view=rev
> > > >> Log:
> > > >> Handle big index in getelementptr instruction
> > > >>
> > > >> CodeGen incorrectly ignores (assert from APInt) constant index
> bigger
> > > >> than 2^64 in getelementptr instruction. This is a test and fix for
> that.
> > > >>
> > > >> Patch by Paweł Bylica!
> > > >>
> > > >> Reviewed By: rnk
> > > >>
> > > >> Subscribers: majnemer, rnk, mcrosier, resistor, llvm-commits
> > > >>
> > > >> Differential Revision: http://reviews.llvm.org/D8219
> > > >>
> > > >> Added:
> > > >>    llvm/trunk/test/CodeGen/X86/getelementptr.ll
> > > >> Modified:
> > > >>    llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp
> > > >>    llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
> > > >>
> > > >
> > > > Hi Owen,
> > > >
> > > > Is this patch OK for the 3.6 branch?
> > >
> > > I approve it.
> > >
> > > —Owen
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150429/de266867/attachment.html>


More information about the llvm-commits mailing list