[PATCH] [SelectionDAG] Unary vector constant folding integer legality fixes

Simon Pilgrim llvm-dev at redking.me.uk
Tue Apr 28 14:26:07 PDT 2015


In http://reviews.llvm.org/D9282#162777, @ab wrote:

> Is there a way to further reduce the testcase, or even rewrite it from scratch?  I shiver whenever I see autogen ;)
>
> The change LGTM, but you might want to wait for other reviews.


Thanks Ahmed, I'll give it another day to see if anyone else has any comments.

I'll get the test -mcpu fixed - note we need mattr=+avx to force i686 to use xmm registers, otherwise it does a rather messy return of the <4 x float> over the stack which isn't very helpful.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D9282

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list