[PATCH] Add direct moves to/from VSR and exploit them for FP/INT conversions

Bill Schmidt wschmidt at linux.vnet.ibm.com
Fri Apr 10 10:00:50 PDT 2015


With the issues you've already promised to fix, and with one nit I noticed, LGTM.

One question:  I was surprised to see that XSCVUXDSP is unimplemented.  Do we have a work item open to address that?

Thanks,
Bill


REPOSITORY
  rL LLVM

================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:6104
@@ +6103,3 @@
+  // If we have direct moves, we can do all the conversion, skip the store/load
+  // However, without FPCVT we can't do most conversions
+  if (Subtarget.hasDirectMove() && Subtarget.isPPC64() && Subtarget.hasFPCVT())
----------------
Oh look, another missing period!  3.7 demerits.

http://reviews.llvm.org/D8928

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list