[lld] r234558 - Remove redundant parentheses.

Rui Ueyama ruiu at google.com
Thu Apr 9 19:18:24 PDT 2015


Author: ruiu
Date: Thu Apr  9 21:18:23 2015
New Revision: 234558

URL: http://llvm.org/viewvc/llvm-project?rev=234558&view=rev
Log:
Remove redundant parentheses.

Modified:
    lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64RelocationHandler.cpp
    lld/trunk/lib/ReaderWriter/ELF/ARM/ARMRelocationHandler.cpp
    lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonRelocationHandler.cpp
    lld/trunk/lib/ReaderWriter/ELF/X86/X86RelocationHandler.cpp
    lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64RelocationHandler.cpp

Modified: lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64RelocationHandler.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64RelocationHandler.cpp?rev=234558&r1=234557&r2=234558&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64RelocationHandler.cpp (original)
+++ lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64RelocationHandler.cpp Thu Apr  9 21:18:23 2015
@@ -42,7 +42,7 @@ static void relocR_AARCH64_ABS64(uint8_t
 /// \brief R_AARCH64_PREL32 - word32: S + A - P
 static void relocR_AARCH64_PREL32(uint8_t *location, uint64_t P, uint64_t S,
                                   int64_t A) {
-  int32_t result = (int32_t)((S + A) - P);
+  int32_t result = (int32_t)(S + A - P);
   write32le(location, result + (int32_t)read32le(location));
 }
 
@@ -84,7 +84,7 @@ static void relocR_AARCH64_ADR_PREL_PG_H
 /// \brief R_AARCH64_ADR_PREL_LO21 - S + A - P
 static void relocR_AARCH64_ADR_PREL_LO21(uint8_t *location, uint64_t P,
                                          uint64_t S, int64_t A) {
-  uint64_t result = (S + A) - P;
+  uint64_t result = S + A - P;
   uint32_t immlo = result & 0x3;
   uint32_t immhi = result & 0x1FFFFC;
   immlo = immlo << 29;
@@ -114,7 +114,7 @@ static void relocR_AARCH64_ADD_ABS_LO12_
 }
 
 static void relocJump26(uint8_t *location, uint64_t P, uint64_t S, int64_t A) {
-  int32_t result = (int32_t)((S + A) - P);
+  int32_t result = (int32_t)(S + A - P);
   result &= 0x0FFFFFFC;
   result >>= 2;
   DEBUG(llvm::dbgs() << "\t\tHandle " << LLVM_FUNCTION_NAME << " -";
@@ -128,7 +128,7 @@ static void relocJump26(uint8_t *locatio
 /// \brief R_AARCH64_CONDBR19
 static void relocR_AARCH64_CONDBR19(uint8_t *location, uint64_t P, uint64_t S,
                                     int64_t A) {
-  int32_t result = (int32_t)((S + A) - P);
+  int32_t result = (int32_t)(S + A - P);
   result &= 0x01FFFFC;
   result <<= 3;
   DEBUG(llvm::dbgs() << "\t\tHandle " << LLVM_FUNCTION_NAME << " -";

Modified: lld/trunk/lib/ReaderWriter/ELF/ARM/ARMRelocationHandler.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/ARM/ARMRelocationHandler.cpp?rev=234558&r1=234557&r2=234558&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/ARM/ARMRelocationHandler.cpp (original)
+++ lld/trunk/lib/ReaderWriter/ELF/ARM/ARMRelocationHandler.cpp Thu Apr  9 21:18:23 2015
@@ -441,7 +441,7 @@ static void relocR_ARM_ALU_PC_GN_NC(uint
 /// \brief R_ARM_ALU_PC_G0_NC - ((S + A) | T) - P => S + A - P
 static void relocR_ARM_ALU_PC_G0_NC(uint8_t *location, uint64_t P, uint64_t S,
                                     int64_t A) {
-  int32_t result = (int32_t)((S + A) - P);
+  int32_t result = (int32_t)(S + A - P);
 
   if (result < 0)
     llvm_unreachable(
@@ -460,7 +460,7 @@ static void relocR_ARM_ALU_PC_G0_NC(uint
 /// \brief R_ARM_ALU_PC_G1_NC - ((S + A) | T) - P => S + A - P
 static void relocR_ARM_ALU_PC_G1_NC(uint8_t *location, uint64_t P, uint64_t S,
                                     int64_t A) {
-  int32_t result = (int32_t)((S + A) - P);
+  int32_t result = (int32_t)(S + A - P);
 
   if (result < 0)
     llvm_unreachable(
@@ -479,7 +479,7 @@ static void relocR_ARM_ALU_PC_G1_NC(uint
 /// \brief R_ARM_LDR_PC_G2 - S + A - P
 static void relocR_ARM_LDR_PC_G2(uint8_t *location, uint64_t P, uint64_t S,
                                  int64_t A) {
-  int32_t result = (int32_t)((S + A) - P);
+  int32_t result = (int32_t)(S + A - P);
 
   if (result < 0)
     llvm_unreachable(

Modified: lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonRelocationHandler.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonRelocationHandler.cpp?rev=234558&r1=234557&r2=234558&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonRelocationHandler.cpp (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonRelocationHandler.cpp Thu Apr  9 21:18:23 2015
@@ -38,7 +38,7 @@ static uint32_t scatterBits(uint32_t val
 
 static void relocBNPCREL(uint8_t *loc, uint64_t P, uint64_t S, uint64_t A,
                          int32_t nBits) {
-  int32_t result = (uint32_t)(((S + A) - P) >> 2);
+  int32_t result = (uint32_t)((S + A - P) >> 2);
   int32_t range = 1 << nBits;
   if (result < range && result > -range) {
     result = scatterBits(result, findv4bitmask(loc));

Modified: lld/trunk/lib/ReaderWriter/ELF/X86/X86RelocationHandler.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/X86/X86RelocationHandler.cpp?rev=234558&r1=234557&r2=234558&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/X86/X86RelocationHandler.cpp (original)
+++ lld/trunk/lib/ReaderWriter/ELF/X86/X86RelocationHandler.cpp Thu Apr  9 21:18:23 2015
@@ -24,7 +24,7 @@ static int reloc32(uint8_t *location, ui
 
 /// \brief R_386_PC32 - word32: S + A - P
 static int relocPC32(uint8_t *location, uint64_t P, uint64_t S, uint64_t A) {
-  uint32_t result = (uint32_t)((S + A) - P);
+  uint32_t result = (uint32_t)(S + A - P);
   write32le(location, result + read32le(location));
   return 0;
 }

Modified: lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64RelocationHandler.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64RelocationHandler.cpp?rev=234558&r1=234557&r2=234558&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64RelocationHandler.cpp (original)
+++ lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64RelocationHandler.cpp Thu Apr  9 21:18:23 2015
@@ -23,7 +23,7 @@ static void reloc64(uint8_t *location, u
 
 /// \brief R_X86_64_PC32 - word32: S + A - P
 static void relocPC32(uint8_t *location, uint64_t P, uint64_t S, int64_t A) {
-  uint32_t result = (uint32_t)((S + A) - P);
+  uint32_t result = (uint32_t)(S + A - P);
   write32le(location, result + read32le(location));
 }
 
@@ -50,14 +50,14 @@ static void reloc16(uint8_t *location, u
 
 /// \brief R_X86_64_PC16 - word16: S + A - P
 static void relocPC16(uint8_t *location, uint64_t P, uint64_t S, int64_t A) {
-  uint16_t result = (uint16_t)((S + A) - P);
+  uint16_t result = (uint16_t)(S + A - P);
   write16le(location, result | read16le(location));
   // TODO: Check for overflow.
 }
 
 /// \brief R_X86_64_PC64 - word64: S + A - P
 static void relocPC64(uint8_t *location, uint64_t P, uint64_t S, uint64_t A) {
-  int64_t result = (uint64_t)((S + A) - P);
+  int64_t result = (uint64_t)(S + A - P);
   write64le(location, result | read64le(location));
 }
 





More information about the llvm-commits mailing list