[lld] r234557 - Do not use default arguments for trivial functions.
Rui Ueyama
ruiu at google.com
Thu Apr 9 19:15:14 PDT 2015
Author: ruiu
Date: Thu Apr 9 21:15:13 2015
New Revision: 234557
URL: http://llvm.org/viewvc/llvm-project?rev=234557&view=rev
Log:
Do not use default arguments for trivial functions.
Modified:
lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonRelocationHandler.cpp
Modified: lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonRelocationHandler.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonRelocationHandler.cpp?rev=234557&r1=234556&r2=234557&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonRelocationHandler.cpp (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonRelocationHandler.cpp Thu Apr 9 21:15:13 2015
@@ -170,22 +170,21 @@ static void relocHexGOT11_X(uint8_t *loc
}
static void relocHexGOTRELSigned(uint8_t *loc, uint64_t P, uint64_t S,
- uint64_t A, uint64_t GOT, int shiftBits = 0) {
+ uint64_t A, uint64_t GOT, int shiftBits) {
int32_t result = (int32_t)((S + A - GOT) >> shiftBits);
result = scatterBits(result, findv4bitmask(loc));
write32le(loc, result | read32le(loc));
}
static void relocHexGOTRELUnsigned(uint8_t *loc, uint64_t P, uint64_t S,
- uint64_t A, uint64_t GOT,
- int shiftBits = 0) {
- uint32_t result = (uint32_t)((S + A - GOT) >> shiftBits);
+ uint64_t A, uint64_t GOT) {
+ uint32_t result = (uint32_t)(S + A - GOT);
result = scatterBits(result, findv4bitmask(loc));
write32le(loc, result | read32le(loc));
}
static void relocHexGOTREL_HILO16(uint8_t *loc, uint64_t P, uint64_t S,
- uint64_t A, uint64_t GOT, int shiftBits = 0) {
+ uint64_t A, uint64_t GOT, int shiftBits) {
int32_t result = (int32_t)((S + A - GOT) >> shiftBits);
result = scatterBits(result, 0x00c03fff);
write32le(loc, result | read32le(loc));
@@ -286,7 +285,7 @@ std::error_code HexagonTargetRelocationH
break;
case R_HEX_GOTREL_LO16:
relocHexGOTREL_HILO16(loc, reloc, target, ref.addend(),
- _targetLayout.getGOTSymAddr());
+ _targetLayout.getGOTSymAddr(), 0);
break;
case R_HEX_GOTREL_HI16:
relocHexGOTREL_HILO16(loc, reloc, target, ref.addend(),
More information about the llvm-commits
mailing list