[PATCH] Disable Mac OS crash reporter in unittests

[Pete Cooper]

> On Apr 7, 2015, at 11:28 AM, Reid Kleckner <rnk at google.com> wrote:
> 
> We already do this in llvm::sys::PrintStackTraceOnErrorSignal. You could setenv("LLVM_DISABLE_CRASH_REPORT", "1") to get this behavior.
Yeah, thats where I found the code to do it :)

But what i didn’t notice was that gtest calls PrintStackTraceOnErrorSignal. Should’ve seen that.

How about if i add a boolean to PrintStackTraceOnErrorSignal to say whether to disable crash reporting?  I think in this case we should disable it even without the env variable for the unittests.

Cheers,
Pete
> 
> Either way is probably fine.
> 
> On Tue, Apr 7, 2015 at 11:21 AM, Pete Cooper <peter_cooper at apple.com <mailto:peter_cooper at apple.com>> wrote:
> Hi Justin
> 
> Please review this patch which disables the crash reporter in the unit tests.  This makes tests using EXPECT_DEATH stop taking an unreasonably long time to run.  For example:
> 
> [----------] 47 tests from APFloatTest (51250 ms total)
> 
> to
> 
> [----------] 47 tests from APFloatTest (765 ms total)
> 
> Cheers,
> Pete
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu <mailto:llvm-commits at cs.uiuc.edu>
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits <http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits>
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150407/34fc2f25/attachment.html>