<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Apr 7, 2015, at 11:28 AM, Reid Kleckner <<a href="mailto:rnk@google.com" class="">rnk@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">We already do this in llvm::sys::PrintStackTraceOnErrorSignal. You could setenv("LLVM_DISABLE_CRASH_REPORT", "1") to get this behavior.</div></div></blockquote>Yeah, thats where I found the code to do it :)</div><div><br class=""></div><div>But what i didn’t notice was that gtest calls PrintStackTraceOnErrorSignal. Should’ve seen that.</div><div><br class=""></div><div>How about if i add a boolean to PrintStackTraceOnErrorSignal to say whether to disable crash reporting? I think in this case we should disable it even without the env variable for the unittests.</div><div><br class=""></div><div>Cheers,</div><div>Pete</div><div><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class=""><br class=""></div><div class="">Either way is probably fine.</div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, Apr 7, 2015 at 11:21 AM, Pete Cooper <span dir="ltr" class=""><<a href="mailto:peter_cooper@apple.com" target="_blank" class="">peter_cooper@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Justin<br class="">
<br class="">
Please review this patch which disables the crash reporter in the unit tests. This makes tests using EXPECT_DEATH stop taking an unreasonably long time to run. For example:<br class="">
<br class="">
[----------] 47 tests from APFloatTest (51250 ms total)<br class="">
<br class="">
to<br class="">
<br class="">
[----------] 47 tests from APFloatTest (765 ms total)<br class="">
<br class="">
Cheers,<br class="">
Pete<br class="">
<br class="">
<br class="">_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@cs.uiuc.edu" class="">llvm-commits@cs.uiuc.edu</a><br class="">
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br class="">
<br class=""></blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></body></html>