[patch][pr22947] Use sext in fast isel

Rafael EspĂ­ndola rafael.espindola at gmail.com
Mon Apr 6 15:11:03 PDT 2015


New patch attached changing the IR instead.

On 6 April 2015 at 17:23, Eric Christopher <echristo at gmail.com> wrote:
> Ah right. That's... both obvious and non-obvious without some thought. :)
>
> That said, can you fix the testcases to do the right thing here? I think
> instead of truncating and zero extending the value it should and with i8.
>
> -eric
>
> On Mon, Apr 6, 2015 at 1:28 PM Rafael EspĂ­ndola <rafael.espindola at gmail.com>
> wrote:
>>
>> On 6 April 2015 at 16:23, Eric Christopher <echristo at gmail.com> wrote:
>> > Hi Rafael,
>> >
>> > The changes to the mips fast isel test are worrying. From looking at the
>> > testcase it's materializing a constant 1 and you have it now
>> > materializing a
>> > constant -1 (extended) into the register.
>> >
>>
>> I think that is a bug fix, no? "i1 1" is -1.
>>
>> Cheers,
>> Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: text/x-patch
Size: 3378 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150406/886238d0/attachment.bin>


More information about the llvm-commits mailing list