[patch][pr22947] Use sext in fast isel

Eric Christopher echristo at gmail.com
Mon Apr 6 14:23:35 PDT 2015


Ah right. That's... both obvious and non-obvious without some thought. :)

That said, can you fix the testcases to do the right thing here? I think
instead of truncating and zero extending the value it should and with i8.

-eric

On Mon, Apr 6, 2015 at 1:28 PM Rafael EspĂ­ndola <rafael.espindola at gmail.com>
wrote:

> On 6 April 2015 at 16:23, Eric Christopher <echristo at gmail.com> wrote:
> > Hi Rafael,
> >
> > The changes to the mips fast isel test are worrying. From looking at the
> > testcase it's materializing a constant 1 and you have it now
> materializing a
> > constant -1 (extended) into the register.
> >
>
> I think that is a bug fix, no? "i1 1" is -1.
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150406/bc2aad39/attachment.html>


More information about the llvm-commits mailing list