[PATCH] Add support for lldb remote test
Ying Chen
chying at google.com
Wed Apr 1 12:28:20 PDT 2015
================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:310
@@ +309,3 @@
+ 'remote_port' : stdout.split(':')[1].rstrip(),
+ 'remote_dir' : stdout.split(':')[2].rstrip()}
+ f.addStep(SetProperty(name="get remote target",
----------------
sivachandra wrote:
> You should put the remote config in a JSON file. That will eliminate parsing. Something like remote_cfg.json. You can generate this JSON from Python interpreter (and need not hand create it).
That is probably a good idea. I have to learn more about JSON.
This will require Json parser installed, like 'jq', is that right?
================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:313
@@ +312,3 @@
+ command="cat remote.cfg",
+ extract_fn=getRemoteCfg,
+ description="get remote target",
----------------
sivachandra wrote:
> For my knowledge: Do the extracted dictionary keys become properties automagically?
Yes, dictionary keys returned from extract_fn will be added to property list. This code has been verified.
================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:367
@@ -251,3 +366,3 @@
*args,
**kwargs):
----------------
sivachandra wrote:
> Nit: Fix the indentation of the function params here to align with the opening '('.
This should be ok based on PEP8.
https://www.python.org/dev/peps/pep-0008/
http://reviews.llvm.org/D8711
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list