[PATCH] Add support for lldb remote test

[Siva Chandra]

Mostly LGTM.
You should probably add vharron to the reviews, or at least add him as a subscriber so that he in the know of the changes you are making, and also of the changes that I am suggesting.


================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:310
@@ +309,3 @@
+               'remote_port' : stdout.split(':')[1].rstrip(),
+               'remote_dir' : stdout.split(':')[2].rstrip()}
+    f.addStep(SetProperty(name="get remote target",
----------------
You should put the remote config in a JSON file. That will eliminate parsing. Something like remote_cfg.json. You can generate this JSON from Python interpreter (and need not hand create it).

================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:313
@@ +312,3 @@
+                          command="cat remote.cfg",
+                          extract_fn=getRemoteCfg,
+                          description="get remote target",
----------------
For my knowledge: Do the extracted dictionary keys become properties automagically?

================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:367
@@ -251,3 +366,3 @@
             *args,
             **kwargs):
 
----------------
Nit: Fix the indentation of the function params here to align with the opening '('.

http://reviews.llvm.org/D8711

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/