[PATCH] Don't add sanitizer init function directly into module constructors

Kostya Serebryany kcc at google.com
Tue Mar 31 17:06:30 PDT 2015


> Yes; Darwin. Dynamic linker is expecting module initializer to be defined within the module itself, otherwise it says:

>  dyld: initializer function <address> not in mapped image


Interesting. Does this mean that you are porting tsan/msan to Darwin? 
This, especially for msan, could be a great challenge.

> > The change touches 3 sanitizers that have 3 different primary maintainers

> 

> >  It might be simpler to split this patch into several:

> 

> > 

> 

> > - move checkInterfaceFunction w/o other functionality changes

> 

> > - update each of the sanitizers.

> 

> 

> Makes sense; will do that. I am abandoning this revision, and will submit 2/3 new. Could you please let me know who are primary maintainers for each sanitizer, so that I add correct reviewers?


Let's do like this:
asan/common: samsonov@
msan: eugenis@
tsan: dvyukov@
CC me to all of them.


http://reviews.llvm.org/D8754

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list