[PATCH] Don't add sanitizer init function directly into module constructors
Ismail Pazarbasi
ismail.pazarbasi at gmail.com
Tue Mar 31 16:50:15 PDT 2015
Thanks for quick response!
In http://reviews.llvm.org/D8754#150169, @kcc wrote:
> > > This prevents these sanitizers be used in certain cases,
>
> >
>
>
> Can you give an example?
Yes; Darwin. Dynamic linker is expecting module initializer to be defined within the module itself, otherwise it says:
dyld: initializer function <address> not in mapped image
> Also, please add tests to test/Instrumentation/*Sanitizer
Yes, this is clearly forgotten. I was rushing to submit this.
> The change touches 3 sanitizers that have 3 different primary maintainers
> It might be simpler to split this patch into several:
>
> - move checkInterfaceFunction w/o other functionality changes
> - update each of the sanitizers.
Makes sense; will do that. I am abandoning this revision, and will submit 2/3 new. Could you please let me know who are primary maintainers for each sanitizer, so that I add correct reviewers?
http://reviews.llvm.org/D8754
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list