[PATCH] Disable passes on optnone functions

[David Blaikie]

On Mon, Mar 30, 2015 at 10:11 AM, Paul Robinson <
Paul_Robinson at playstation.sony.com> wrote:

> In http://reviews.llvm.org/D2369#148975, @dblaikie wrote:
>
> > The little "comment" dropdown above the comment box (the one at the
> bottom
> >  of the review, after all the diff changes) has an "abandon" option,
> which I
> >  think is what we're doing for code reviews that end up not going
> anywhere.
>
>
> Okay, I see that.  But in fact this review did "go somewhere" and a later
> version
> of the patch was actually committed.


I think the mental model to use here is that /this/ change was abandoned -
albeit in favor of some other, related change. But if /this/ change went
somewhere it would've been this one that was approved/committed (if it was
this change that got approved/committed, but it was just done outside Phab,
you could manually mark this as accepted, and close it & just mention the
revision in the message when you close the revision)


>   So "abandon" is semantically wrong, even
> if it would do something to cause it to not be on lists of open reviews.
> (BTW I am completely sympathetic about getting it off lists of open
> reviews.
> I'm just at a loss for how to navigate this, shall we say, help-challenged
> product.)
>
> > (there's also a "close" option too, I'm not sure of the distinction)
>
>
> Not seeing that in the drop-down list of Actions, where is that?
>

I have a close option - though apparently it only works if the revision has
been accepted. Not sure what the equivalent action is on the owner's side
(nor why it shows me an option that's not valid for the current state).


>
>
> http://reviews.llvm.org/D2369
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150330/dfc27c40/attachment.html>