[PATCH] Disable passes on optnone functions
Paul Robinson
Paul_Robinson at playstation.sony.com
Mon Mar 30 10:11:42 PDT 2015
In http://reviews.llvm.org/D2369#148975, @dblaikie wrote:
> The little "comment" dropdown above the comment box (the one at the bottom
> of the review, after all the diff changes) has an "abandon" option, which I
> think is what we're doing for code reviews that end up not going anywhere.
Okay, I see that. But in fact this review did "go somewhere" and a later version
of the patch was actually committed. So "abandon" is semantically wrong, even
if it would do something to cause it to not be on lists of open reviews.
(BTW I am completely sympathetic about getting it off lists of open reviews.
I'm just at a loss for how to navigate this, shall we say, help-challenged product.)
> (there's also a "close" option too, I'm not sure of the distinction)
Not seeing that in the drop-down list of Actions, where is that?
http://reviews.llvm.org/D2369
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list