[PATCH] Fix 'leading zeros' caveat of StringRef::compare_numeric()

Chandler Carruth chandlerc at gmail.com
Sun Mar 29 16:47:16 PDT 2015


This adds lots of code and makes the code harder to read in order to handle this case.

Is there a specific problem you're addressing here? Can you work to make the code more readable rather than less readable if we need to support this use case?

Also, this ignores the common usage of a leading zero to indicate octal. I'm somewhat worried about StringRef having divergent behavior there.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D7388

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list