[PATCH] [MCInstPrinter] Enable MCInstPrinter to change its behavior based on the per-function subtarget

Eric Christopher echristo at gmail.com
Fri Mar 27 12:40:28 PDT 2015


Excellent. We're in agreement then.

One inline comment and then LGTM.

-eric


================
Comment at: utils/TableGen/AsmWriterInst.h:56
@@ -55,1 +55,3 @@
 
+    unsigned PassSubtarget;
+
----------------
Document this please. What it's for, why it exists, etc. Possibly even a FIXME for "remove after all ports are updated".

http://reviews.llvm.org/D8668

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list