[PATCH] [MCInstPrinter] Enable MCInstPrinter to change its behavior based on the per-function subtarget

Akira Hatanaka ahatanak at gmail.com
Fri Mar 27 12:12:02 PDT 2015


In http://reviews.llvm.org/D8668#148025, @echristo wrote:

> Clever hack with PassSubtarget to make sure you don't have to update all of the ports and reduce churn I gather?


Yes, I did it to reduce churn.

> Looks pretty decent in general. First follow up will be to remove the passing of the subtarget to the inst printer constructor yes? (Also the ARM port I think needs to be fixed up).


My plan was to commit this patch first (possibly separating the changes in AArch64InstPrinter and the test case from the rest), make similar changes to ARM and X86, and then remove the passing of the subtarget and remove MCInstPrinter::AvailableFeatures.

> -eric



http://reviews.llvm.org/D8668

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list