[PATCH] LLD: Inherit constructors. No functionality change.

[Duncan P. N. Exon Smith]

> On 2015-Mar-25, at 13:36, David Blaikie <dblaikie at gmail.com> wrote:
> 
> 
> 
> On Wed, Mar 25, 2015 at 1:31 PM, Rui Ueyama <ruiu at google.com> wrote:
> Yup, I'd like to hear from more audiences about their opinions.
> 
> We already have a few instances of perfect forwarding in LLVm - mostly in more core libraries than this, but I don't think it's too interesting. Especially in this really basic/common/cliched case - there's nothing else here to make it particularly confusing, it's just the classic application of variadic templates/perfect forwarding.
> 
> (but yeah - I'm hardly the best test subject for this, so more opinions are certainly valuable)

I agree with David here.

>  
> 
> On Wed, Mar 25, 2015 at 1:28 PM, Simon Atanasyan <simon at atanasyan.com> wrote:
> As to me the patch looks good. The code becomes much shorter. But I do not think that `std::forward` is a common idiom for constructor inheritance. Might it confuse somebody?
> 
> 
> REPOSITORY
>   rL LLVM
> 
> http://reviews.llvm.org/D8616
> 
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
> 
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits