[PATCH] [mips] [IAS] Refactor the function which checks for the availability of AT. NFC.

Daniel Sanders daniel.sanders at imgtec.com
Tue Mar 24 04:06:24 PDT 2015


I agree with changing the int's to unsigned but I think the re-factor is going in the wrong direction at the moment. Instead of partially inlining MipsAsmParser::getATReg() and having a predicate function with side effects (error messages), I'd instead either rename it getATRegIndex() to make it clear it's an index rather than an internal register number, or I'd move the getReg() call inside the function so that it does return an internal register number.


http://reviews.llvm.org/D8478

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list