[rfc][patch] Refactoring how we handle symbols for the end of sections

Eric Christopher echristo at gmail.com
Mon Mar 23 14:03:46 PDT 2015


This is a good improvement.

LGTM.

Thanks!

-eric

On Mon, Mar 23, 2015 at 1:56 PM Rafael EspĂ­ndola <rafael.espindola at gmail.com>
wrote:

> Eric had so objections to the way unique sections were handled. I
> decided then to split this patch in two.
>
> The first one (attached) is just the refactoring on how different
> passes get a label a the end of a section.
>
> OK?
>
>
> On 20 March 2015 at 16:57, Pete Cooper <peter_cooper at apple.com> wrote:
> >
> >> On Mar 20, 2015, at 1:51 PM, Rafael EspĂ­ndola <
> rafael.espindola at gmail.com> wrote:
> >>
> >>>> Sounds like a nice cleanup to me, although I don't know this code
> >>>> well enough to confirm.
> >>
> >> All dependencies are in.
> >>
> >> A rebased patch is attached.
> >>
> >> OK?
> > Hi Rafael
> >
> > Please add a comment to say that EmitFunctionHeader() returns whether
> the section is unique.  After that LGTM.
> >
> > Cheers,
> > Pete
> >>
> >> Cheers,
> >> Rafael
> >> <t.patch>
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150323/8c59ca10/attachment.html>


More information about the llvm-commits mailing list