[rfc][patch] Refactoring how we handle symbols for the end of sections

Rafael EspĂ­ndola rafael.espindola at gmail.com
Mon Mar 23 13:56:35 PDT 2015


Eric had so objections to the way unique sections were handled. I
decided then to split this patch in two.

The first one (attached) is just the refactoring on how different
passes get a label a the end of a section.

OK?


On 20 March 2015 at 16:57, Pete Cooper <peter_cooper at apple.com> wrote:
>
>> On Mar 20, 2015, at 1:51 PM, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
>>
>>>> Sounds like a nice cleanup to me, although I don't know this code
>>>> well enough to confirm.
>>
>> All dependencies are in.
>>
>> A rebased patch is attached.
>>
>> OK?
> Hi Rafael
>
> Please add a comment to say that EmitFunctionHeader() returns whether the section is unique.  After that LGTM.
>
> Cheers,
> Pete
>>
>> Cheers,
>> Rafael
>> <t.patch>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: text/x-patch
Size: 7494 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150323/acbdbd61/attachment.bin>


More information about the llvm-commits mailing list