[PATCH] [lld][ELF][ARM] Implement static (initial exec) TLS model

Shankar Kalpathi Easwaran shankarke at gmail.com
Tue Mar 17 12:15:52 PDT 2015


================
Comment at: lib/ReaderWriter/ELF/ARM/ARMRelocationPass.cpp:50
@@ +49,3 @@
+// .got values
+const uint8_t ARMGotAtomContent[4] = {0};
+
----------------
only class declarations are allowed to be under anonymous namespace.

================
Comment at: lib/ReaderWriter/ELF/ARM/ARMTargetHandler.h:33
@@ +32,3 @@
+
+  uint64_t getTPOffset() const {
+    if (_tpOff.hasValue())
----------------
you can remove the const and remove mutable from _tpOff too.

http://reviews.llvm.org/D8353

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list