[PATCH] [lld][ELF][ARM] Implement static (initial exec) TLS model
Rui Ueyama
ruiu at google.com
Tue Mar 17 12:02:49 PDT 2015
LGTM
================
Comment at: lib/ReaderWriter/ELF/ARM/ARMRelocationPass.cpp:207
@@ +206,3 @@
+ const_cast<Reference &>(ref).setTarget(
+ static_cast<Derived *>(this)->getTLSTPOFF32(target));
+ } else {
----------------
I guess early return is preferred. You can return std::error_code() here so that you can remove "else" below.
================
Comment at: lib/ReaderWriter/ELF/ARM/ARMTargetHandler.h:37
@@ +36,3 @@
+
+ for (const auto &phdr : *this->_programHeader)
+ if (phdr->p_type == llvm::ELF::PT_TLS) {
----------------
Can you add braces after this for?
http://reviews.llvm.org/D8353
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list