Tell lit.cfg about more Windows triples

Gao, Yunzhong yunzhong_gao at playstation.sony.com
Fri Mar 13 20:24:45 PDT 2015


Hi,

Due to bug#17463, there is code in llvm/test/lit.cfg to append elf to the host triple when running lli

tests on Windows. However, the host triple on my 64-bit PC is x86_64-pc-windows-msvc, so it does

not match any of the expected patterns. I am wondering if it makes sense to make the following

change to lit.cfg, although, it does have the effect of creating a strange -windows-msvc-elf triple.

What do you think?



--- llvm/test/lit.cfg

+++ llvm/test/lit.cfg

@@ -181,7 +181,7 @@ lli = 'lli'

# we don't support COFF in MCJIT well enough for the tests, force ELF format on

# Windows.  FIXME: the process target triple should be used here, but this is

# difficult to obtain on Windows.

-if re.search(r'cygwin|mingw32|windows-gnu|win32', config.host_triple):

+if re.search(r'cygwin|mingw32|windows-gnu|windows-msvc|win32', config.host_triple):

   lli += ' -mtriple='+config.host_triple+'-elf'

config.substitutions.append( ('%lli', lli ) )

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150314/e03df6ef/attachment.html>


More information about the llvm-commits mailing list