<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"MS Mincho";
panose-1:2 2 6 9 4 2 5 8 3 4;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@MS Mincho";
panose-1:2 2 6 9 4 2 5 8 3 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:"Calibri","sans-serif";}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoPlainText">Hi,<o:p></o:p></p>
<p class="MsoPlainText">Due to bug#17463, there is code in llvm/test/lit.cfg to append elf to the host triple when running lli<o:p></o:p></p>
<p class="MsoPlainText">tests on Windows. However, the host triple on my 64-bit PC is x86_64-pc-windows-msvc, so it does<o:p></o:p></p>
<p class="MsoPlainText">not match any of the expected patterns. I am wondering if it makes sense to make the following<o:p></o:p></p>
<p class="MsoPlainText">change to lit.cfg, although, it does have the effect of creating a strange -windows-msvc-elf triple.<o:p></o:p></p>
<p class="MsoPlainText">What do you think?<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">--- llvm/test/lit.cfg<o:p></o:p></p>
<p class="MsoPlainText">+++ llvm/test/lit.cfg<o:p></o:p></p>
<p class="MsoPlainText">@@ -181,7 +181,7 @@ lli = 'lli'<o:p></o:p></p>
<p class="MsoPlainText"># we don't support COFF in MCJIT well enough for the tests, force ELF format on<o:p></o:p></p>
<p class="MsoPlainText"># Windows. FIXME: the process target triple should be used here, but this is<o:p></o:p></p>
<p class="MsoPlainText"># difficult to obtain on Windows.<o:p></o:p></p>
<p class="MsoPlainText">-if re.search(r'cygwin|mingw32|windows-gnu|win32', config.host_triple):<o:p></o:p></p>
<p class="MsoPlainText">+if re.search(r'cygwin|mingw32|windows-gnu|windows-msvc|win32', config.host_triple):<o:p></o:p></p>
<p class="MsoPlainText"> lli += ' -mtriple='+config.host_triple+'-elf'<o:p></o:p></p>
<p class="MsoPlainText">config.substitutions.append( ('%lli', lli ) )<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>