[PATCH] asan: optimization experiments

Kostya Serebryany kcc at google.com
Wed Mar 11 15:16:15 PDT 2015


================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:926
@@ +925,3 @@
+  // negatives) and make the decision on the optimization.
+  uint32_t Exp = ClForceExperiment;
+
----------------
Do I understand correctly that this patch does not set Exp to anything interesting by default,
and that will be added in the following patches? 

================
Comment at: lib/asan/asan_thread.h:121
@@ +120,3 @@
+  // Rathole to pass experiments mask from __asan_exp_loadN to __asan_loadN.
+  u32 report_experiment_;
+
----------------
That's gross. Why not just pass an extra parameter??

http://reviews.llvm.org/D8198

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list