[PATCH] asan: optimization experiments

[Dmitry Vyukov]

PTAL


================
Comment at: AddressSanitizer.cpp:1077
@@ +1076,3 @@
+// to report the actual access size.
+void AddressSanitizer::instrumentUnusualAddress(Instruction *I, Value *Addr,
+                                                uint32_t TypeSize, bool IsWrite,
----------------
kcc wrote:
> The name is misleading. The address is not unusual, but size or alignment is.
> 
Done

================
Comment at: lib/asan/asan_report.cc:945
@@ -944,1 +944,3 @@
 
+  // Optimization experiments mask (see the comment in
+  // lib/Transforms/Instrumentation/AddressSanitizer.cpp:instrumentMop).
----------------
kcc wrote:
> the rt is used with other compilers. I would prefer to have a full comment here
Extended it to some degree. Will extend more when we decide how to handle experiments in runtime, otherwise I don't know how to extend it.

================
Comment at: lib/asan/asan_rtl.cc:171
@@ +170,3 @@
+  }                                                                            \
+  extern "C" NOINLINE INTERFACE_ATTRIBUTE                                      \
+  void __asan_exp_##type##size(uptr addr, u32 exp) {                           \
----------------
kcc wrote:
> can you avoid so much duplication here? 
Done

http://reviews.llvm.org/D8198

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/