[Patch] Support for Nuxi CloudABI

Eric Christopher echristo at gmail.com
Sat Mar 7 01:14:07 PST 2015


If you'd follow up to the thread replying I'll give you an explicit LGTM.

-eric

On Sat, Mar 7, 2015 at 12:50 AM Ed Schouten <ed at nuxi.nl> wrote:

> Hi Eric,
>
> 2015-03-07 1:45 GMT+01:00 Eric Christopher <echristo at gmail.com>:
> > Could use some unittests for the triple changes. :)
>
> Thanks for the pointer! I've added the following test:
>
> Index: unittests/ADT/TripleTest.cpp
> ===================================================================
> --- unittests/ADT/TripleTest.cpp        (revision 231492)
> +++ unittests/ADT/TripleTest.cpp        (working copy)
> @@ -159,6 +159,12 @@
>    EXPECT_EQ(Triple::UnknownVendor, T.getVendor());
>    EXPECT_EQ(Triple::UnknownOS, T.getOS());
>
> +  T = Triple("x86_64-unknown-cloudabi");
> +  EXPECT_EQ(Triple::x86_64, T.getArch());
> +  EXPECT_EQ(Triple::UnknownVendor, T.getVendor());
> +  EXPECT_EQ(Triple::CloudABI, T.getOS());
> +  EXPECT_EQ(Triple::UnknownEnvironment, T.getEnvironment());
> +
>    T = Triple("huh");
>    EXPECT_EQ(Triple::UnknownArch, T.getArch());
>  }
>
> --
> Ed Schouten <ed at nuxi.nl>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150307/d2156717/attachment.html>


More information about the llvm-commits mailing list