<div dir="ltr">If you'd follow up to the thread replying I'll give you an explicit LGTM.<br><br><div>-eric</div></div><br><div class="gmail_quote">On Sat, Mar 7, 2015 at 12:50 AM Ed Schouten <<a href="mailto:ed@nuxi.nl">ed@nuxi.nl</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Eric,<br>
<br>
2015-03-07 1:45 GMT+01:00 Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>>:<br>
> Could use some unittests for the triple changes. :)<br>
<br>
Thanks for the pointer! I've added the following test:<br>
<br>
Index: unittests/ADT/TripleTest.cpp<br>
==============================<u></u>==============================<u></u>=======<br>
--- unittests/ADT/TripleTest.cpp        (revision 231492)<br>
+++ unittests/ADT/TripleTest.cpp        (working copy)<br>
@@ -159,6 +159,12 @@<br>
   EXPECT_EQ(Triple::<u></u>UnknownVendor, T.getVendor());<br>
   EXPECT_EQ(Triple::UnknownOS, T.getOS());<br>
<br>
+  T = Triple("x86_64-unknown-<u></u>cloudabi");<br>
+  EXPECT_EQ(Triple::x86_64, T.getArch());<br>
+  EXPECT_EQ(Triple::<u></u>UnknownVendor, T.getVendor());<br>
+  EXPECT_EQ(Triple::CloudABI, T.getOS());<br>
+  EXPECT_EQ(Triple::<u></u>UnknownEnvironment, T.getEnvironment());<br>
+<br>
   T = Triple("huh");<br>
   EXPECT_EQ(Triple::UnknownArch, T.getArch());<br>
 }<br>
<br>
--<br>
Ed Schouten <<a href="mailto:ed@nuxi.nl" target="_blank">ed@nuxi.nl</a>><br>
</blockquote></div>