[PATCH] [Windows] Implementing backtracing of self

David Majnemer david.majnemer at gmail.com
Thu Mar 5 10:13:51 PST 2015


REPOSITORY
  rL LLVM

================
Comment at: llvm/trunk/lib/Support/Windows/Signals.inc:181-183
@@ +180,5 @@
+  machineType = IMAGE_FILE_MACHINE_AMD64;
+#else
+  machineType = IMAGE_FILE_MACHINE_I386;
+#endif
+
----------------
Might be good to make this guarded by `#elif define(_M_IX86)`.

================
Comment at: llvm/trunk/lib/Support/Windows/Signals.inc:393
@@ +392,3 @@
+  StackFrame.AddrFrame.Offset = Context.Rbp;
+#else
+  StackFrame.AddrPC.Offset = Context.Eip;
----------------
This should be `#elif defined(_M_IX86)`

http://reviews.llvm.org/D8068

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list