[PATCH] [compiler-rt] Symbolizer refactoring: Make LibbacktraceSymbolizer adopt the SymbolizerTool interface
Kuba Brecka
kuba.brecka at gmail.com
Mon Mar 2 14:28:24 PST 2015
> CHECK_EQ(addr, last->info.address);
> Should this be first->info.address?
For `llvm-symbolizer`, we always have the same `addr` in all frames coming from one `SymbolizePC(addr)` request. I am assuming the same holds for libbacktrace symbolizer. If that's really the case, I'd even vote for having both checks (addr == first->info.address == last->info.address).
Btw. do we have any buildbots that is at least building with `SANITIZER_LIBBACKTRACE=1`?
http://reviews.llvm.org/D7971
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list