[PATCH] [compiler-rt] Symbolizer refactoring: Make LibbacktraceSymbolizer adopt the SymbolizerTool interface
Alexey Samsonov
vonosmas at gmail.com
Mon Mar 2 14:14:12 PST 2015
LGTM
> > On a related note, let me know if you want to replace AddressInfo::FillAddressAndModuleInfo with AddressInfo::FillModuleInfo, or I should do it myself.
>
>
> I'll do it in a subsequent patch.
Thanks!
================
Comment at: lib/sanitizer_common/sanitizer_symbolizer_libbacktrace.cc:103
@@ -99,1 +102,3 @@
}
+ CHECK_EQ(addr, last->info.address);
+ return &last->info;
----------------
Should this be first->info.address?
http://reviews.llvm.org/D7971
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list